Issue 9006053: frog await: allow errors after the await within try-catch blocks.

Issue 9006053: frog await: allow errors after the await within try-catch blocks. (Closed)

Created:
8 years, 12 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 12 months ago

Reviewers:
mattsh, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

frog await: allow errors after the await within try-catch blocks. Committed: https://code.google.com/p/dart/source/detail?r=2859

Patch Set 3 : '' #

Total comments: 2

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -28 lines)			Patch
M	corelib/src/implementation/future_implementation.dart	View	1	1 chunk	+1 line, -0 lines	2 comments	Download
M	frog/await/transformation.dart	View	1	8 chunks	+44 lines, -25 lines	0 comments	Download
M	frog/tests/await/await.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
A	frog/tests/await/src/NestedTryCatch2Test.dart	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A	frog/tests/await/src/NestedTryCatch3Test.dart	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
A	frog/tests/await/src/NestedTryCatch4Test.dart	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
A	frog/tests/await/src/NestedTryCatch5Test.dart	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
A	frog/tests/await/src/NestedTryCatchTest.dart	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
M	frog/tests/await/src/TryCatch8Test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	frog/tests/await/src/TryCatch9Test.dart	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

http://codereview.chromium.org/9006053/diff/4001/corelib/src/implementation/future_implementation.dart File corelib/src/implementation/future_implementation.dart (right): http://codereview.chromium.org/9006053/diff/4001/corelib/src/implementation/future_implementation.dart#newcode103 corelib/src/implementation/future_implementation.dart:103: break; Matt - Something I wanted to make sure ...

8 years, 12 months ago (2011-12-28 20:11:59 UTC) #1

mattsh

8 years, 12 months ago (2011-12-28 20:55:57 UTC) #2

LGTM

http://codereview.chromium.org/9006053/diff/4001/corelib/src/implementation/f...
File corelib/src/implementation/future_implementation.dart (right):

http://codereview.chromium.org/9006053/diff/4001/corelib/src/implementation/f...
corelib/src/implementation/future_implementation.dart:103: break;
On 2011/12/28 20:11:59, sigmund wrote:
> Matt - Something I wanted to make sure here is this change. I am assuming that
> once a handler returns true, there is no need to keep calling the others. This
> resembles how try-catch blocks work.

Yes.  This is good.

Expand Messages | Collapse Messages