Issue 9006012: Workaround for referencing type args in the $named_$lookupRTT method.

Issue 9006012: Workaround for referencing type args in the $named_$lookupRTT method. (Closed)

Created:
9 years ago by zundel

Modified:
9 years ago

Reviewers:
codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Workaround for referencing type args in the $named_$lookupRTT method. These lookup methods references $typeArgs as if they were a parameter to the method, but that method actually takes no arguments. There is no 'this' context either, but at least JS compiler doesn't complain about that. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2660

Patch Set 1 : Fixes 2 problems emitting code from inside generating a factory method #

Total comments: 4

Patch Set 2 : Fixed formatting issue #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -32 lines)			Patch
	M	compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java	View		5 chunks	+31 lines, -9 lines	0 comments	Download
	M	compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java	View	1	3 chunks	+22 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zundel

I broke the build on dartc-release this morning and this fixes it. I need to ...

9 years ago (2011-12-20 19:29:35 UTC) #1

codefu

Nits http://codereview.chromium.org/9006012/diff/2002/compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java File compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java (right): http://codereview.chromium.org/9006012/diff/2002/compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java#newcode471 compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java:471: JsExpression typeArgContextExpr = hasTypeArguments ? buildTypeArgsReferenceFromThis(classElement) line length. ...

9 years ago (2011-12-20 19:49:49 UTC) #2

zundel

Updated patch http://codereview.chromium.org/9006012/diff/2002/compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java File compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java (right): http://codereview.chromium.org/9006012/diff/2002/compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java#newcode471 compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java:471: JsExpression typeArgContextExpr = hasTypeArguments ? buildTypeArgsReferenceFromThis(classElement) On ...

9 years ago (2011-12-20 19:56:17 UTC) #3

codefu

9 years ago (2011-12-20 19:57:20 UTC) #4

On 2011/12/20 19:56:17, zundel wrote:
> Updated patch
> 
>
http://codereview.chromium.org/9006012/diff/2002/compiler/java/com/google/dar...
> File
compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java
> (right):
> 
>
http://codereview.chromium.org/9006012/diff/2002/compiler/java/com/google/dar...
>
compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java:471:
> JsExpression typeArgContextExpr = hasTypeArguments ?
> buildTypeArgsReferenceFromThis(classElement)
> On 2011/12/20 19:49:50, codefu wrote:
> > line length.
> 
> Done.
> 
>
http://codereview.chromium.org/9006012/diff/2002/compiler/java/com/google/dar...
>
compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java:745:
> typeArgs = buildTypeArgsReferenceFromThis(classElement);
> On 2011/12/20 19:49:50, codefu wrote:
> > indentation
> 
> Done.

LGTM as far as I can see.

Expand Messages | Collapse Messages