Issue 9005010: Fix broken build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9005010: Fix broken build (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix broken build TBR=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2643

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	tests/standalone/src/ListInputStreamTest.dart	View		1 chunk	+2 lines, -2 lines	2 comments	Download
	M	tests/standalone/standalone.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm http://codereview.chromium.org/9005010/diff/1/tests/standalone/src/ListInputStreamTest.dart File tests/standalone/src/ListInputStreamTest.dart (right): http://codereview.chromium.org/9005010/diff/1/tests/standalone/src/ListInputStreamTest.dart#newcode175 tests/standalone/src/ListInputStreamTest.dart:175: //testListInputStreamPipe1(); Is this on purpose? We should have ...

9 years ago (2011-12-21 07:30:40 UTC) #2

Søren Gjesse

9 years ago (2011-12-21 07:54:26 UTC) #3

http://codereview.chromium.org/9005010/diff/1/tests/standalone/src/ListInputS...
File tests/standalone/src/ListInputStreamTest.dart (right):

http://codereview.chromium.org/9005010/diff/1/tests/standalone/src/ListInputS...
tests/standalone/src/ListInputStreamTest.dart:175: //testListInputStreamPipe1();
On 2011/12/21 07:30:41, Mads Ager wrote:
> Is this on purpose? We should have a TODO and file a bug to get the reenabled.


I am going to work on re-enabling this right away.

Expand Messages | Collapse Messages