Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 9004031: Fix windows build create_sdk. (Closed)

Created:
9 years ago by Emily Fortuna
Modified:
9 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix windows build create_sdk. Committed: https://code.google.com/p/dart/source/detail?r=2667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M dart.gyp View 2 chunks +5 lines, -1 line 0 comments Download
M frog/dart-frog.gyp View 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Strangely, when the variables are defined non-conditionally, the Windows build fails.
9 years ago (2011-12-20 20:07:13 UTC) #1
Jennifer Messerly
lgtm
9 years ago (2011-12-20 20:39:39 UTC) #2
dgrove
9 years ago (2011-12-20 20:53:26 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698