Issue 8999015: Generate AST node for factory methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8999015: Generate AST node for factory methods. (Closed)

Created:
9 years ago by ahe

Modified:
9 years ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, floitsch, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generate AST node for factory methods. Committed: https://code.google.com/p/dart/source/detail?r=2717

Patch Set 1 #

Patch Set 2 : Fix type errors #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -15 lines)			Patch
M	dart/frog/leg/scanner/listener.dart	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download
M	dart/frog/leg/tree/nodes.dart	View		3 chunks	+4 lines, -0 lines	0 comments	Download
M	dart/frog/presubmit.py	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View		6 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Still LGTM, even though it'd be nice to get named constructors in. It looks like ...

9 years ago (2011-12-21 19:32:14 UTC) #4

ahe

9 years ago (2011-12-21 19:49:26 UTC) #5

On 2011/12/21 19:32:14, ngeoffray wrote:
> Still LGTM, even though it'd be nice to get named constructors in. It looks
like
> endMethod (for a constructor) and endFactoryMethod now behaves differently for
> name/return type.

Well they can't behave the same. You can have this:

factory foo.bar.baz() => null;

That can't occur for constructors. Do  you have an alternative suggestion?

Expand Messages | Collapse Messages