Issue 8996011: - Trigger old-gen GCs when needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8996011: - Trigger old-gen GCs when needed. (Closed)

Created:
9 years ago by Ivan Posva

Modified:
9 years ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Trigger old-gen GCs when needed. - Sweep large pages. - Handle free list elements when calculating sizes. Committed: https://code.google.com/p/dart/source/detail?r=2593

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -6 lines)			Patch
M	vm/gc_sweeper.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	vm/heap.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	vm/heap.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	vm/heap_test.cc	View	1 2	2 chunks	+28 lines, -0 lines	0 comments	Download
M	vm/pages.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	vm/raw_object.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cshapiro

lgtm Unit test? http://codereview.chromium.org/8996011/diff/1/vm/heap.cc File vm/heap.cc (right): http://codereview.chromium.org/8996011/diff/1/vm/heap.cc#newcode77 vm/heap.cc:77: if (FLAG_verbose_gc) { Lines 77-82 are ...

9 years ago (2011-12-19 17:44:48 UTC) #2

Ivan Posva

9 years ago (2011-12-19 19:24:23 UTC) #3

Thanks! Added unit test.

-Ivan

http://codereview.chromium.org/8996011/diff/1/vm/heap.cc
File vm/heap.cc (right):

http://codereview.chromium.org/8996011/diff/1/vm/heap.cc#newcode77
vm/heap.cc:77: if (FLAG_verbose_gc) {
On 2011/12/19 17:44:48, cshapiro wrote:
> Lines 77-82 are a copy of lines 58-63.  Maybe it is time to pull this code out
> and place it into a separate method?

I am planning to pull the GC stats gathering out into a whole separate class,
which will remove this duplication here.

Expand Messages | Collapse Messages

Issue 8996011: - Trigger old-gen GCs when needed. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages