Implement chromium component.

Implement chromium component.


BUG=
TEST=tools/test.dart --component=chromium

Committed: https://code.google.com/p/dart/source/detail?r=2695

[Bill Hesse, 2011-12-19 16:18:58]

Not quite finished and polished, but it works, also in parallel with dartium and
vm components.  New temp directory solution will be backported to dartium.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:549: // Returns a Map with keys 'executable'
and 'args'.
This function will be removed again.

[Mads Ager (google), 2011-12-20 09:03:01]

LGTM with a couple of comments.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:438: testRelativeDir = 
testRelativePath.substring(0, start - 1);
Two spaces after the '='. Remove one of them.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:444: print('''
Delete.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:502: String dartcExecutable =
'$dartDir/$buildDir/compiler/bin/dartc';
Use the TestUtils dartc compilation helper to get this so we only have one place
to change for the location of dartc.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:525: expectations,
optionsFromFile['isNegative']);
Move isNegative to a separate line.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:531: {'dartium': 'application/dart',
Creating a map every time and performing a lookup seems like a strange way to do
an if or a switch. I would rather go with the simpler direct approach.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:534: String get scriptName() => tempDir.path
+
Ditto.

[Bill Hesse, 2011-12-21 15:33:43]

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:438: testRelativeDir = 
testRelativePath.substring(0, start - 1);
On 2011/12/20 09:03:01, Mads Ager wrote:
> Two spaces after the '='. Remove one of them.

Done.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:502: String dartcExecutable =
'$dartDir/$buildDir/compiler/bin/dartc';
On 2011/12/20 09:03:01, Mads Ager wrote:
> Use the TestUtils dartc compilation helper to get this so we only have one
place
> to change for the location of dartc.

Done.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:525: expectations,
optionsFromFile['isNegative']);
On 2011/12/20 09:03:01, Mads Ager wrote:
> Move isNegative to a separate line.

Done.

http://codereview.chromium.org/8995009/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:531: {'dartium': 'application/dart',
On 2011/12/20 09:03:01, Mads Ager wrote:
> Creating a map every time and performing a lookup seems like a strange way to
do
> an if or a switch. I would rather go with the simpler direct approach.

Done.