Issue 8994002: Do not use the NegativeTest ending for multi tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8994002: Do not use the NegativeTest ending for multi tests. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not use the NegativeTest ending for multi tests. The NegativeTest ending has meaning and should not be used for multitests that are split into multiple files each with their own expectation based on the annotation. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2576

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, -10 lines)			Patch
	D	tests/language/src/ClassKeywordNegativeTest.dart	View		1 chunk	+0 lines, -11 lines	0 comments	Download
	A +	tests/language/src/ClassKeywordTest.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages