Implement string interpolation up to SSA.

Implement string interpolation up to SSA.

Committed: https://code.google.com/p/dart/source/detail?r=2630

[ngeoffray, 2011-12-20 11:54:45]

LGTM!

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:969: // The key may be a LiteralString or a
StringInterpolation.
StringInterpolation should be rejected by someone though, right?

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/scanner.dart
File dart/frog/leg/scanner/scanner.dart (right):

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/scanner.d...
dart/frog/leg/scanner/scanner.dart:567: next === $$) {
Is a boolean check really that bad here, compared to duplicate code between
tokenizeIdentifier and tokenizeIdentifierNoDollar?

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/scanner.d...
dart/frog/leg/scanner/scanner.dart:589: int
tokenizeIdentifierOrKeywordNoDollar(int next) {
The other method is called tokenizeKeywordOrIdentifier, maybe follow the same
naming? And again, a boolean check was too expensive?

[ahe, 2011-12-20 13:19:24]

Hi Nicolas,

Thanks for your comments. I'll submit this now, but I'd appreciate if you could
look at the differences between patch set 2 and 3 where I address some of your
comments.

Cheers,
Peter

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:969: // The key may be a LiteralString or a
StringInterpolation.
On 2011/12/20 11:54:45, ngeoffray wrote:
> StringInterpolation should be rejected by someone though, right?

Yes. I looked at the specification. There is a bad test somewhere. Thinking
about it, I think I should use parseExpression() in parseMapLiteralEntry and
report an error if  key.asString() === null.

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/scanner.dart
File dart/frog/leg/scanner/scanner.dart (right):

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/scanner.d...
dart/frog/leg/scanner/scanner.dart:567: next === $$) {
On 2011/12/20 11:54:45, ngeoffray wrote:
> Is a boolean check really that bad here, compared to duplicate code between
> tokenizeIdentifier and tokenizeIdentifierNoDollar?

I don't know. I'll try to clean this up in a follow up CL.

http://codereview.chromium.org/8993009/diff/1/dart/frog/leg/scanner/scanner.d...
dart/frog/leg/scanner/scanner.dart:589: int
tokenizeIdentifierOrKeywordNoDollar(int next) {
On 2011/12/20 11:54:45, ngeoffray wrote:
> The other method is called tokenizeKeywordOrIdentifier, maybe follow the same
> naming? And again, a boolean check was too expensive?

Next CL.

[ngeoffray, 2011-12-20 14:03:14]

Still LGTM!