Make the repeating argument to timers optional.

Make the repeating argument to timers optional.


R=sgjesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2577

[Søren Gjesse, 2011-12-19 12:10:45]

This is related to issue 286,
http://code.google.com/p/dart/issues/detail?id=268.

I think we should consider removing the repeating argument altogether and
instead add the Timer.repeating constructor.

I don't think there are that many cases where the repeating state has to be
passed as an argument.

http://codereview.chromium.org/8992007/diff/1/samples/socket/SocketExample.dart
File samples/socket/SocketExample.dart (right):

http://codereview.chromium.org/8992007/diff/1/samples/socket/SocketExample.da...
samples/socket/SocketExample.dart:56: }, 500, true);
Maybe "repeating: true" here and in places where true is passed. Otherwise have
the Timer.repeating constructor.

[Mads Ager (google), 2011-12-19 12:29:33]

I agree. Replaced with a named constructor. Please take another look.

[Søren Gjesse, 2011-12-19 12:31:36]

lgtm

http://codereview.chromium.org/8992007/diff/3001/runtime/bin/timer_impl.dart
File runtime/bin/timer_impl.dart (right):

http://codereview.chromium.org/8992007/diff/3001/runtime/bin/timer_impl.dart#...
runtime/bin/timer_impl.dart:17: static Timer createTimer(void callback(Timer
timer),
_createTimer?

[Mads Ager (google), 2011-12-19 12:34:37]

http://codereview.chromium.org/8992007/diff/3001/runtime/bin/timer_impl.dart
File runtime/bin/timer_impl.dart (right):

http://codereview.chromium.org/8992007/diff/3001/runtime/bin/timer_impl.dart#...
runtime/bin/timer_impl.dart:17: static Timer createTimer(void callback(Timer
timer),
On 2011/12/19 12:31:36, Søren Gjesse wrote:
> _createTimer?

Done.