Issue 8989019: Implement list based output stream and add pipe to list based input streams

Issue 8989019: Implement list based output stream and add pipe to list based input streams (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement list based output stream and add pipe to list based input streams R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2641

Patch Set 2 : Addressed review comments from ager@ #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+299 lines, -67 lines)			Patch
M	runtime/bin/builtin_sources.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/input_stream.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
D	runtime/bin/list_input_stream.dart	View		1 chunk	+0 lines, -61 lines	0 comments	Download
A	runtime/bin/list_stream.dart	View	1	1 chunk	+147 lines, -0 lines	0 comments	Download
M	runtime/bin/stream_util.dart	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	tests/standalone/src/ListInputStreamTest.dart	View	1	4 chunks	+53 lines, -2 lines	0 comments	Download
A	tests/standalone/src/ListOutputStreamTest.dart	View	1	1 chunk	+90 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

http://codereview.chromium.org/8989019/diff/1/runtime/bin/list_stream.dart File runtime/bin/list_stream.dart (right): http://codereview.chromium.org/8989019/diff/1/runtime/bin/list_stream.dart#newcode5 runtime/bin/list_stream.dart:5: class ListInputStream extends _BaseDataInputStream implements InputStream { Line 1 ...

9 years ago (2011-12-20 14:52:46 UTC) #1

Mads Ager (google)

lgtm http://codereview.chromium.org/8989019/diff/1/runtime/bin/list_stream.dart File runtime/bin/list_stream.dart (right): http://codereview.chromium.org/8989019/diff/1/runtime/bin/list_stream.dart#newcode104 runtime/bin/list_stream.dart:104: List<int> content() => _bufferList.readBytes(_bufferList.length); contents? http://codereview.chromium.org/8989019/diff/1/runtime/bin/list_stream.dart#newcode121 runtime/bin/list_stream.dart:121: // ...

9 years ago (2011-12-20 15:52:45 UTC) #2

Søren Gjesse

9 years ago (2011-12-20 16:02:30 UTC) #3

http://codereview.chromium.org/8989019/diff/1/runtime/bin/list_stream.dart
File runtime/bin/list_stream.dart (right):

http://codereview.chromium.org/8989019/diff/1/runtime/bin/list_stream.dart#ne...
runtime/bin/list_stream.dart:104: List<int> content() =>
_bufferList.readBytes(_bufferList.length);
On 2011/12/20 15:52:46, Mads Ager wrote:
> contents?

Done.

http://codereview.chromium.org/8989019/diff/1/runtime/bin/list_stream.dart#ne...
runtime/bin/list_stream.dart:121: // output stream does not wait for any
tramsmission. Schedule
On 2011/12/20 15:52:46, Mads Ager wrote:
> transmission

Done.

Expand Messages | Collapse Messages