Implement weak persistent handles in the Dart API.

Implement weak persistent handles in the Dart API.

Committed: https://code.google.com/p/dart/source/detail?r=2607

[Ivan Posva, 2011-12-19 22:41:35]

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:512: Dart_PeerFinalizer callback) {
We will need to add the peer pointer here.

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:804: // nothing should be invalidated or
cleared
Also the weak and non-weak handles should still be pointing to the same object?

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:817: // nothing should be invalidated or
cleared
ditto.

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_state.h
File runtime/vm/dart_api_state.h (right):

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_state.h#...
runtime/vm/dart_api_state.h:92: explicit Visitor(ObjectPointerVisitor* visitor,
Kind kind) {
explicit not needed here.

[cshapiro, 2011-12-20 00:58:57]

PTAL

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:512: Dart_PeerFinalizer callback) {
Sure.  I was going to leave this for the next change but I have gone ahead and
updated the signature of this function and its internals to receive the peer
pointer in addition to the callback.

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:804: // nothing should be invalidated or
cleared
Sounds good.  Done.

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:817: // nothing should be invalidated or
cleared
On 2011/12/19 22:41:36, Ivan Posva wrote:
> ditto.

Done.

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_state.h
File runtime/vm/dart_api_state.h (right):

http://codereview.chromium.org/8984006/diff/2001/runtime/vm/dart_api_state.h#...
runtime/vm/dart_api_state.h:92: explicit Visitor(ObjectPointerVisitor* visitor,
Kind kind) {
Right, done.

[Ivan Posva, 2011-12-20 01:32:34]

LGTM -ip

http://codereview.chromium.org/8984006/diff/8001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8984006/diff/8001/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:98: typedef void (*Dart_PeerFinalizer)(void* peer);
As discussed we should add the Dart_Handle to this as well. Next change though.