Issue 8980014: Make 'class' and 'extends' into real keywords, per language spec 0.06 .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8980014: Make 'class' and 'extends' into real keywords, per language spec 0.06 . (Closed)

Created:
9 years ago by dgrove

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make 'class' and 'extends' into real keywords, per language spec 0.06 . Committed: https://code.google.com/p/dart/source/detail?r=2595

Patch Set 1 #

Patch Set 2 : Make 'class' and 'extends' into real keywords, per language spec 0.06 . #

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -128 lines)			Patch
M	frog/minfrog	View	1	37 chunks	+96 lines, -96 lines	0 comments	Download
M	frog/scripts/token_info.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	frog/token_kind.g.dart	View	1	1 chunk	+28 lines, -28 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

On 2011/12/17 06:58:51, dgrove wrote: lgtm, but can you also update scripts/token_gen.py and rerun verify ...

9 years ago (2011-12-19 20:04:45 UTC) #2

dgrove

done. On 2011/12/19 20:04:45, John Messerly wrote: > On 2011/12/17 06:58:51, dgrove wrote: > > ...

9 years ago (2011-12-19 21:24:08 UTC) #3

Jennifer Messerly

9 years ago (2011-12-19 22:56:57 UTC) #4

On 2011/12/19 21:24:08, dgrove wrote:
> done.
> On 2011/12/19 20:04:45, John Messerly wrote:
> > On 2011/12/17 06:58:51, dgrove wrote:
> > 
> > lgtm, but can you also update scripts/token_gen.py and rerun verify it
> produces
> > same output?
> > 
> > should just need to change "True" to "False" for these lines (True means
> pseudo
> > keyword):
> >   Keyword('CLASS', "class", True),
> >   Keyword('EXTENDS', "extends", True),

new version lgtm too :)

Expand Messages | Collapse Messages