Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 8973005: Fix bug 846: (Closed)

Created:
9 years ago by Ivan Posva
Modified:
9 years ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse
Visibility:
Public.

Description

Fix bug 846: - Only execute timers which were pending prior to the wakeup to avoid busy looping. - Prevent double notification for timers. Committed: https://code.google.com/p/dart/source/detail?r=2500

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M bin/timer_impl.dart View 4 chunks +32 lines, -9 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
9 years ago (2011-12-16 01:25:15 UTC) #1
siva
http://codereview.chromium.org/8973005/diff/1/bin/timer_impl.dart File bin/timer_impl.dart (right): http://codereview.chromium.org/8973005/diff/1/bin/timer_impl.dart#newcode30 bin/timer_impl.dart:30: timer._notifyEventHandler(); We need to call notifyEventHandler only if addTimerToList ...
9 years ago (2011-12-16 01:42:02 UTC) #2
siva
9 years ago (2011-12-16 01:43:16 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698