Issue 8972006: Don't treat warnings as errors when compiling minfrog items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8972006: Don't treat warnings as errors when compiling minfrog items. (Closed)

Created:
9 years ago by Emily Fortuna

Modified:
9 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't treat warnings as errors when compiling minfrog items. TBR=sigmund, Committed: https://code.google.com/p/dart/source/detail?r=2495

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	tools/testing/perf_testing/create_graph.py	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

9 years ago (2011-12-16 00:24:31 UTC) #2

lgtm (with fix below)

http://codereview.chromium.org/8972006/diff/1/tools/testing/perf_testing/crea...
File tools/testing/perf_testing/create_graph.py (right):

http://codereview.chromium.org/8972006/diff/1/tools/testing/perf_testing/crea...
tools/testing/perf_testing/create_graph.py:60: if append
I believe the : should stay on this line?

Expand Messages | Collapse Messages