Issue 8972004: Rename and fix json frog library in SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8972004: Rename and fix json frog library in SDK (Closed)

Created:
9 years ago by danrubel

Modified:
9 years ago

Reviewers:
vsm, jimhug, dgrove, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Rename and fix json frog library in SDK Committed: https://code.google.com/p/dart/source/detail?r=2558

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -136 lines)			Patch
M	frog/lib/frog_json_sources.gypi	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
D	frog/lib/json.dart	View	1	1 chunk	+0 lines, -38 lines	0 comments	Download
D	frog/lib/json.js	View	1	1 chunk	+0 lines, -86 lines	0 comments	Download
A +	frog/lib/json_frog.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	frog/lib/json_frog.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	frog/reader.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/create_sdk.py	View	1 2 3	1 chunk	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jimhug

lgtm - as well as I can tell. Please get Dan's comments on sdk packaging ...

9 years ago (2011-12-16 17:51:03 UTC) #2

dgrove

9 years ago (2011-12-16 17:55:19 UTC) #3

lgtm

lgtm with 1 change.

http://codereview.chromium.org/8972004/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8972004/diff/1/tools/create_sdk.py#newcode212
tools/create_sdk.py:212: json_frog_dest_dir = join(LIB, 'json')
This should be json_dest_dir.

Expand Messages | Collapse Messages