Use deopt on some instructions that have not collected type feedback when optimizing compierl kic...

Use deopt on some instructions that have not collected type feedback when optimizing compierl kicks in. Optimize SAR.
Committed: https://code.google.com/p/dart/source/detail?r=2487

[regis, 2011-12-15 22:18:42]

LGTM with questions

http://codereview.chromium.org/8972002/diff/6/runtime/vm/opt_code_generator_i...
File runtime/vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8972002/diff/6/runtime/vm/opt_code_generator_i...
runtime/vm/opt_code_generator_ia32.cc:701: __ SmiTag(EAX);
No overflow check?

http://codereview.chromium.org/8972002/diff/6/tests/language/src/BitOperation...
File tests/language/src/BitOperationsTest.dart (right):

http://codereview.chromium.org/8972002/diff/6/tests/language/src/BitOperation...
tests/language/src/BitOperationsTest.dart:20: Expect.equals(0x10000000000000000,
1 << 64);
How about
Expect.equals(0x40000000, 0x04000000 << 4);
and
Expect.equals(0x4000000000000000, 0x0400000000000000 << 4);
?

http://codereview.chromium.org/8972002/diff/6/tests/language/src/Deoptimizati...
File tests/language/src/DeoptimizationTest.dart (right):

http://codereview.chromium.org/8972002/diff/6/tests/language/src/Deoptimizati...
tests/language/src/DeoptimizationTest.dart:171: static smiRightShift() {
How about smiLeftShift()?

[srdjan, 2011-12-15 22:27:14]

Moved DeoptimizationTest.dart to standalone since Javascript cannot handle
shifts > 0x1F, and VM can.

http://codereview.chromium.org/8972002/diff/6/runtime/vm/opt_code_generator_i...
File runtime/vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8972002/diff/6/runtime/vm/opt_code_generator_i...
runtime/vm/opt_code_generator_ia32.cc:701: __ SmiTag(EAX);
On 2011/12/15 22:18:43, regis wrote:
> No overflow check?

Right shift cannot overflow.

http://codereview.chromium.org/8972002/diff/6/tests/language/src/BitOperation...
File tests/language/src/BitOperationsTest.dart (right):

http://codereview.chromium.org/8972002/diff/6/tests/language/src/BitOperation...
tests/language/src/BitOperationsTest.dart:20: Expect.equals(0x10000000000000000,
1 << 64);
On 2011/12/15 22:18:43, regis wrote:
> How about
> Expect.equals(0x40000000, 0x04000000 << 4);
> and
> Expect.equals(0x4000000000000000, 0x0400000000000000 << 4);
> ?

Added (though my CL does not affect left shift operations).

http://codereview.chromium.org/8972002/diff/6/tests/language/src/Deoptimizati...
File tests/language/src/DeoptimizationTest.dart (right):

http://codereview.chromium.org/8972002/diff/6/tests/language/src/Deoptimizati...
tests/language/src/DeoptimizationTest.dart:171: static smiRightShift() {
On 2011/12/15 22:18:43, regis wrote:
> How about smiLeftShift()?

Once I do changes to the left shift. This CL changes only right shift.

[regis, 2011-12-15 22:38:20]

http://codereview.chromium.org/8972002/diff/6/runtime/vm/opt_code_generator_i...
File runtime/vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8972002/diff/6/runtime/vm/opt_code_generator_i...
runtime/vm/opt_code_generator_ia32.cc:701: __ SmiTag(EAX);
On 2011/12/15 22:27:16, srdjan wrote:
> On 2011/12/15 22:18:43, regis wrote:
> > No overflow check?
> 
> Right shift cannot overflow.

Ah, the 'l' in 'sarl' does not stand for 'left' :-)