Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 8970013: Make some additional classes hidden so that they are not generated when not (Closed)

Created:
9 years ago by Emily Fortuna
Modified:
9 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make some additional classes hidden so that they are not generated when not needed (fixes FF and Safari). Committed: https://code.google.com/p/dart/source/detail?r=2505

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M client/dom/frog/dom_frog.dart View 1 9 chunks +9 lines, -9 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Emily Fortuna
9 years ago (2011-12-16 00:42:01 UTC) #1
Emily Fortuna
9 years ago (2011-12-16 00:42:03 UTC) #2
Jennifer Messerly
another idea I had here was we could add a "maybe" annotation, so the code ...
9 years ago (2011-12-16 00:58:46 UTC) #3
Siggi Cherem (dart-lang)
lgtm
9 years ago (2011-12-16 01:50:21 UTC) #4
sra1
http://codereview.chromium.org/8970013/diff/6001/client/dom/frog/dom_frog.dart File client/dom/frog/dom_frog.dart (right): http://codereview.chromium.org/8970013/diff/6001/client/dom/frog/dom_frog.dart#newcode7697 client/dom/frog/dom_frog.dart:7697: class SVGPathSeg native "*SVGPathSeg" { Where was SVGPathSeg a ...
9 years ago (2011-12-16 04:05:11 UTC) #5
sra1
9 years ago (2011-12-16 05:22:46 UTC) #6
On 2011/12/16 00:58:46, John Messerly wrote:
> another idea I had here was we could add a "maybe" annotation, so the code
> generated was more like:
>     if (Float32Array) Float32Array.prototype = ...

This won't work if e.g. Float32Array exists but can be constructed only via
calling a createFloat32Array method on some 'factory'.  Then you need hidden.

> 
> (but hidden seems like a faster way to get going)

Powered by Google App Engine
This is Rietveld 408576698