One small step towards sanity

One small step towards sanity

Make 'class' a proper keyword, and 'extends' too. Adjusting the VM compiler to the language spec.
Committed: https://code.google.com/p/dart/source/detail?r=2533

[srdjan, 2011-12-16 19:03:58]

http://codereview.chromium.org/8968021/diff/1/tests/language/src/PseudoKWTest...
File tests/language/src/PseudoKWTest.dart (left):

http://codereview.chromium.org/8968021/diff/1/tests/language/src/PseudoKWTest...
tests/language/src/PseudoKWTest.dart:16: var extends = 0;
How about adding failing tests for using class and extends as pseudo keywords
(using the ///)

[srdjan, 2011-12-16 19:04:10]

LGTM

On 2011/12/16 19:03:58, srdjan wrote:
>
http://codereview.chromium.org/8968021/diff/1/tests/language/src/PseudoKWTest...
> File tests/language/src/PseudoKWTest.dart (left):
> 
>
http://codereview.chromium.org/8968021/diff/1/tests/language/src/PseudoKWTest...
> tests/language/src/PseudoKWTest.dart:16: var extends = 0;
> How about adding failing tests for using class and extends as pseudo keywords
> (using the ///)

[hausner, 2011-12-16 19:15:36]

http://codereview.chromium.org/8968021/diff/1/tests/language/src/PseudoKWTest...
File tests/language/src/PseudoKWTest.dart (left):

http://codereview.chromium.org/8968021/diff/1/tests/language/src/PseudoKWTest...
tests/language/src/PseudoKWTest.dart:16: var extends = 0;
On 2011/12/16 19:03:58, srdjan wrote:
> How about adding failing tests for using class and extends as pseudo keywords
> (using the ///)

I think that's a good idea once we have exact semantics for pseudo-keywords or
built-in identifiers defined. Depending on what we define, we would need
negative tests for top-level definitions, class definitions, field and method
names, parameter names etc.

In any case, I put on that now but I'll file a bug to add those test cases.

[ahe, 2011-12-16 23:57:09]

Yay! I thought "class" wasn't a reserved word in JavaScript. How stupid does
that make me look? :-)

I pointed out to Gilad that "import" is also a reserved word in JavaScript.