Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 8966020: Fix named constructors and static methods of hidden native classes. (Closed)

Created:
9 years ago by sra1
Modified:
9 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix named constructors and static methods of hidden native classes. The static methods can't go on the constructor, so they go on a surrogate object. Make sure no global names conflict with either the hidden class's name or the surrogate object. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2547

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -23 lines) Patch
M frog/gen.dart View 1 chunk +1 line, -1 line 0 comments Download
M frog/member.dart View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M frog/minfrog View 1 2 15 chunks +39 lines, -18 lines 0 comments Download
M frog/world.dart View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
9 years ago (2011-12-16 08:07:09 UTC) #1
Jennifer Messerly
9 years ago (2011-12-16 22:09:34 UTC) #2
I'm getting a feeling of creeping complexity of natives. But this change lgtm
:). Nice targeted fixes.

Maybe add a TODO about the renaming in world being more complex than it needs to
be because of the incrementalness.

Powered by Google App Engine
This is Rietveld 408576698