Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 8965071: Push raw_null instead of smi 0 in all places were we setup the return value location before calli... (Closed)

Created:
8 years, 12 months ago by siva
Modified:
8 years, 12 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Push raw_null instead of smi 0 in all places were we setup the return value location before calling into the runtime. Committed: https://code.google.com/p/dart/source/detail?r=2844

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -36 lines) Patch
M vm/stub_code_ia32.cc View 1 2 3 4 5 13 chunks +16 lines, -20 lines 0 comments Download
M vm/stub_code_x64.cc View 1 2 3 4 5 11 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years, 12 months ago (2011-12-28 00:41:55 UTC) #1
Ivan Posva
LGTM -ip
8 years, 12 months ago (2011-12-28 00:43:28 UTC) #2
siva
8 years, 12 months ago (2011-12-28 01:55:30 UTC) #3

          

Powered by Google App Engine
This is Rietveld 408576698