Issue 8962007: Extracted total tests into library and reused them for dartest tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8962007: Extracted total tests into library and reused them for dartest tests. (Closed)

Created:
9 years ago by shauvik

Modified:
9 years ago

Reviewers:
codefu, Kelly Norton

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Hi, I had forgotten to commit the test library. Please review it so that I can put it in. Extracted total tests into library and reused them for dartest tests. Thanks! Committed: https://code.google.com/p/dart/source/detail?r=2556

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+518 lines, -0 lines)			Patch
	A	client/tests/client/samples/total/total_dartest.dart	View		1 chunk	+57 lines, -0 lines	0 comments	Download
	A	client/tests/client/samples/total/total_test_lib.dart	View		1 chunk	+461 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

codefu

9 years ago (2011-12-16 23:48:13 UTC) #2

On 2011/12/16 23:48:00, shauvik wrote:
> Hi,
> 
> Please review for these missing files.
> 
> Thanks,
> Shauvik

LGTM

Expand Messages | Collapse Messages