Issue 8958011: One more factory -> default pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8958011: One more factory -> default pass. (Closed)

Created:
9 years ago by ahe

Modified:
9 years ago

Reviewers:
regis, ngeoffray, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

One more factory -> default pass. Committed: https://code.google.com/p/dart/source/detail?r=2774

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -30 lines)			Patch
M	dart/tests/isolate/src/MintMakerPromiseTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/BlackListedTest.dart	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	dart/tests/language/src/ClassTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/ConstConstructor1NegativeTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/DefaultFactoryLibrary.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/DefaultFactoryTest.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/language/src/DefaultImplementationTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/Factory2Test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/Factory3Test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/FactoryImplementationTest.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/tests/language/src/FactoryNegativeTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/InterfaceFactory1NegativeTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/InterfaceFactory2NegativeTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/InterfaceFactory3NegativeTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/InterfaceFactoryMultiTest.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/language/src/InterfaceFactoryTest.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/language/src/InterfaceTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/NamedParametersTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/src/TypeVariableScopeTest.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages