Update test of type variable bounds to match specification

Update test of type variable bounds to match specification

Committed: https://code.google.com/p/dart/source/detail?r=2573

[ahe, 2011-12-15 08:11:27]

I'll update the status file and file bugs when the reviewers have looked at this
test.

[zundel, 2011-12-15 14:01:16]

http://codereview.chromium.org/8956005/diff/2001/dart/tests/language/src/Type...
File dart/tests/language/src/TypeVariableBoundsTest.dart (right):

http://codereview.chromium.org/8956005/diff/2001/dart/tests/language/src/Type...
dart/tests/language/src/TypeVariableBoundsTest.dart:18: interface IFoo<T extends
num> default Foo<T extends num> {
FYI, frog and dartc have not committed changes to respect the default keyword
yet.

http://codereview.chromium.org/8956005/diff/2001/dart/tests/language/src/Type...
dart/tests/language/src/TypeVariableBoundsTest.dart:59: new Box.makeFoo();
this does not resolve to a constructor when I patch it in.  missing 'factory'
keyword in front of makeFoo() declaration in box?

[ahe, 2011-12-15 14:04:48]

Hi Eric,

Thank you for taking a look.

Cheers,
Peter

http://codereview.chromium.org/8956005/diff/2001/dart/tests/language/src/Type...
File dart/tests/language/src/TypeVariableBoundsTest.dart (right):

http://codereview.chromium.org/8956005/diff/2001/dart/tests/language/src/Type...
dart/tests/language/src/TypeVariableBoundsTest.dart:18: interface IFoo<T extends
num> default Foo<T extends num> {
On 2011/12/15 14:01:17, zundel wrote:
> FYI, frog and dartc have not committed changes to respect the default keyword
> yet.

It looked like things were getting close, but I'll make sure to not cause
unintended failures.

http://codereview.chromium.org/8956005/diff/2001/dart/tests/language/src/Type...
dart/tests/language/src/TypeVariableBoundsTest.dart:59: new Box.makeFoo();
On 2011/12/15 14:01:17, zundel wrote:
> this does not resolve to a constructor when I patch it in.  missing 'factory'
> keyword in front of makeFoo() declaration in box?

Thank you. It should be:

new Box().makeFoo();

[ahe, 2011-12-15 15:55:57]

http://codereview.chromium.org/8956005/diff/2001/dart/tests/language/src/Type...
File dart/tests/language/src/TypeVariableBoundsTest.dart (right):

http://codereview.chromium.org/8956005/diff/2001/dart/tests/language/src/Type...
dart/tests/language/src/TypeVariableBoundsTest.dart:59: new Box.makeFoo();
On 2011/12/15 14:04:48, ahe wrote:
> On 2011/12/15 14:01:17, zundel wrote:
> > this does not resolve to a constructor when I patch it in.  missing
'factory'
> > keyword in front of makeFoo() declaration in box?
> 
> Thank you. It should be:
> 
> new Box().makeFoo();

Done.

[zundel, 2011-12-15 16:07:39]

this test now passes on my updated dartc patch.

http://codereview.chromium.org/8948001

[gbracha, 2011-12-15 17:54:13]

lgtm

[gbracha, 2011-12-15 17:54:57]

lgtm

[ahe, 2011-12-19 12:20:11]

Submitted.