Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 8953025: Promote "class" and "extends" to keywords (Closed)

Created:
9 years ago by ahe
Modified:
9 years ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org, kasperl, floitsch, Lasse Reichstein Nielsen, karlklose
Visibility:
Public.

Description

Promote "class" and "extends" to keywords Committed: https://code.google.com/p/dart/source/detail?r=2571

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M dart/frog/leg/scanner/keyword.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/language-leg.status View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
ahe
http://codereview.chromium.org/8953025/diff/1/dart/tests/language/language-leg.status File dart/tests/language/language-leg.status (right): http://codereview.chromium.org/8953025/diff/1/dart/tests/language/language-leg.status#newcode30 dart/tests/language/language-leg.status:30: ClassKeywordNegativeTest/02: Fail This one uses string interpolation "$class". Since ...
9 years ago (2011-12-19 11:10:08 UTC) #1
kasperl
LGTM.
9 years ago (2011-12-19 11:18:39 UTC) #2
ngeoffray
9 years ago (2011-12-20 09:36:00 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698