Issue 8949039: Make sure a class is resolved before looking up its elements.

Issue 8949039: Make sure a class is resolved before looking up its elements. (Closed)

Created:
9 years ago by ngeoffray

Modified:
9 years ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org, floitsch, Lasse Reichstein Nielsen, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make sure a class is resolved before looking up its elements. Committed: https://code.google.com/p/dart/source/detail?r=2696

Patch Set 2 : '' #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -47 lines)			Patch
M	frog/leg/elements/elements.dart	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	frog/leg/resolver.dart	View	1	3 chunks	+2 lines, -7 lines	0 comments	Download
A +	frog/tests/leg_only/src/StaticField2Test.dart	View		1 chunk	+2 lines, -16 lines	0 comments	Download
A +	frog/tests/leg_only/src/StaticMethod2Test.dart	View		1 chunk	+1 line, -11 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	13 chunks	+23 lines, -9 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

http://codereview.chromium.org/8949039/diff/1/frog/leg/resolver.dart File frog/leg/resolver.dart (right): http://codereview.chromium.org/8949039/diff/1/frog/leg/resolver.dart#newcode311 frog/leg/resolver.dart:311: target = receiverClass.resolve(compiler).lookupLocalElement(name); I will deal with lookupLocalElement -> ...

9 years ago (2011-12-21 13:17:06 UTC) #1

ahe

LGTM! http://codereview.chromium.org/8949039/diff/2002/tests/language/language-leg.status File tests/language/language-leg.status (right): http://codereview.chromium.org/8949039/diff/2002/tests/language/language-leg.status#newcode229 tests/language/language-leg.status:229: NewExpressionTypeArgsFrogTest/02: Fail Please keep them sorted for now, ...

9 years ago (2011-12-21 14:03:31 UTC) #4

BTW: I really like how you changed the call to resolve.

Expand Messages | Collapse Messages