Issue 8935015: Expand ArithmeticTest to include truncate divide corner case and to trigger optimizing compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8935015: Expand ArithmeticTest to include truncate divide corner case and to trigger optimizing compiler. (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
regis, sra1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tests/

Visibility:
Public.

More Reviews

Description

Expand ArithmeticTest to include truncate divide corner case and to trigger optimizing compiler. Committed: https://code.google.com/p/dart/source/detail?r=2410

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	language/src/ArithmeticTest.dart	View	1	3 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8935015/diff/1/language/src/ArithmeticTest.dart File language/src/ArithmeticTest.dart (right): http://codereview.chromium.org/8935015/diff/1/language/src/ArithmeticTest.dart#newcode52 language/src/ArithmeticTest.dart:52: Expect.equals(1 << 30, a ~/ b); You could ...

9 years ago (2011-12-14 00:58:03 UTC) #2

sra1

http://codereview.chromium.org/8935015/diff/1/language/src/ArithmeticTest.dart File language/src/ArithmeticTest.dart (right): http://codereview.chromium.org/8935015/diff/1/language/src/ArithmeticTest.dart#newcode52 language/src/ArithmeticTest.dart:52: Expect.equals(1 << 30, a ~/ b); On 2011/12/14 00:58:03, ...

9 years ago (2011-12-14 01:05:25 UTC) #3

srdjan

9 years ago (2011-12-14 01:14:30 UTC) #4

http://codereview.chromium.org/8935015/diff/1/language/src/ArithmeticTest.dart
File language/src/ArithmeticTest.dart (right):

http://codereview.chromium.org/8935015/diff/1/language/src/ArithmeticTest.dar...
language/src/ArithmeticTest.dart:52: Expect.equals(1 << 30, a ~/ b);
On 2011/12/14 01:05:25, sra1 wrote:
> On 2011/12/14 00:58:03, regis wrote:
> > You could already add a test for 62-bit Smi.
> 
> I would loop, 30 and 62 are not the only choices.

Looping 1..80

Expand Messages | Collapse Messages

Issue 8935015: Expand ArithmeticTest to include truncate divide corner case and to trigger optimizing compiler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages