Create the SDK in dart-sdk directory. The sdk zip file's contents

Create the SDK in dart-sdk directory. The sdk zip file's contents
will be rooted at dart-sdk/ (rather than being root at bin/lib/... ,
as it is today).

Also, add a revision file to the SDK that contains the version number.
Committed: https://code.google.com/p/dart/source/detail?r=2400

[dgrove, 2011-12-13 18:03:18]

danrubel - an fyi that i'm adding a top-level directory to the SDK so that it
unzips more politely.

[Siggi Cherem (dart-lang), 2011-12-13 19:01:00]

lgtm (with comments below)

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode16
tools/upload_sdk.py:16: from os.path import basename, dirname, join
I personally like how this looks in the code, but I think our style guide
requires using os.path.X in the code instead.

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode22
tools/upload_sdk.py:22: LATEST = 'latest'
this var is not used

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode23
tools/upload_sdk.py:23: SDK = 'sdk'
maybe rename to GS_SDK_SUBDIR (for a moment I thought this could be the local
dir that got renamed to dart-sdk)

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode85
tools/upload_sdk.py:85: revision_file.close()
(nit): slightly better style:
with open(join(basename(argv[1]), 'revision'), 'w') as f:
  f.write(revision + '\n')

(close is done automatically, even if an exception is thrown)

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode88
tools/upload_sdk.py:88: sdk_file = 'dart-' + utils.GuessOS() + '-' + revision +
'.zip'
(style nit):
sdk_file = 'dart-%s-%s.zip' % (utils.GuessOS(), revision)

[danrubel, 2011-12-13 22:09:34]

http://codereview.chromium.org/8935008/diff/8001/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://codereview.chromium.org/8935008/diff/8001/tools/upload_sdk.py#newcode19
tools/upload_sdk.py:19:
GSUTIL='/Users/dgrove/repo/dart-bleeding/dart/third_party/gsutil/20110627/gsutil'
Should this 2nd GSUTIL assignment be removed?

[dgrove, 2011-12-13 22:38:41]

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode16
tools/upload_sdk.py:16: from os.path import basename, dirname, join
On 2011/12/13 19:01:00, sigmund wrote:
> I personally like how this looks in the code, but I think our style guide
> requires using os.path.X in the code instead.

Done.

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode22
tools/upload_sdk.py:22: LATEST = 'latest'
On 2011/12/13 19:01:00, sigmund wrote:
> this var is not used

Done.

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode23
tools/upload_sdk.py:23: SDK = 'sdk'
On 2011/12/13 19:01:00, sigmund wrote:
> maybe rename to GS_SDK_SUBDIR (for a moment I thought this could be the local
> dir that got renamed to dart-sdk)

Done.

http://codereview.chromium.org/8935008/diff/2001/tools/upload_sdk.py#newcode85
tools/upload_sdk.py:85: revision_file.close()
On 2011/12/13 19:01:00, sigmund wrote:
> (nit): slightly better style:
> with open(join(basename(argv[1]), 'revision'), 'w') as f:
>   f.write(revision + '\n')
> 
> (close is done automatically, even if an exception is thrown)

Done.

http://codereview.chromium.org/8935008/diff/8001/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://codereview.chromium.org/8935008/diff/8001/tools/upload_sdk.py#newcode19
tools/upload_sdk.py:19:
GSUTIL='/Users/dgrove/repo/dart-bleeding/dart/third_party/gsutil/20110627/gsutil'
Yes. this is what happens when I upload just before running to a meeting.
thanks!
On 2011/12/13 22:09:34, danrubel wrote:
> Should this 2nd GSUTIL assignment be removed?

Done.