Issue 8934010: Optimize truncated divide (intrinsics and inline).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8934010: Optimize truncated divide (intrinsics and inline). (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
regis, sra1

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Optimize truncated divide (intrinsics and inline). Committed: https://code.google.com/p/dart/source/detail?r=2397

Patch Set 1 #

Total comments: 3

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	vm/intrinsifier_ia32.cc	View		2 chunks	+20 lines, -0 lines	2 comments	Download
	M	vm/opt_code_generator_ia32.cc	View		2 chunks	+15 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

On 2011/12/13 19:59:56, regis wrote: > LGTM > > Are tests covering this inline division ...

9 years ago (2011-12-13 20:56:49 UTC) #3

srdjan

9 years ago (2011-12-13 21:29:34 UTC) #5

http://codereview.chromium.org/8934010/diff/1/vm/intrinsifier_ia32.cc
File vm/intrinsifier_ia32.cc (right):

http://codereview.chromium.org/8934010/diff/1/vm/intrinsifier_ia32.cc#newcode373
vm/intrinsifier_ia32.cc:373: __ SmiTag(EAX);
On 2011/12/13 21:12:08, sra1 wrote:
> MIN_SMI / -1 is not a Smi.

Thanks, fixing it now.

Expand Messages | Collapse Messages