Issue 8934004: Add support for getting OS error information for creating temporary directories

Issue 8934004: Add support for getting OS error information for creating temporary directories (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for getting OS error information for creating temporary directories R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2385

Patch Set 3 : Added path to exception messages #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -44 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/directory.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/bin/directory.cc	View		1 chunk	+31 lines, -4 lines	0 comments	Download
M	runtime/bin/directory.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/directory_impl.dart	View	1 2	5 chunks	+29 lines, -7 lines	0 comments	Download
M	runtime/bin/directory_posix.cc	View	1 2	2 chunks	+32 lines, -13 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View		2 chunks	+53 lines, -15 lines	0 comments	Download
M	tests/standalone/src/DirectoryTest.dart	View	1 2	2 chunks	+41 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

This should also reveal the OS error related to the current Windows buildbot redness.

9 years ago (2011-12-13 13:00:00 UTC) #1

Bill Hesse

LGTM. http://codereview.chromium.org/8934004/diff/2001/runtime/bin/directory_impl.dart File runtime/bin/directory_impl.dart (right): http://codereview.chromium.org/8934004/diff/2001/runtime/bin/directory_impl.dart#newcode7 runtime/bin/directory_impl.dart:7: int _errorCode; // Set to OS error code ...

9 years ago (2011-12-13 13:51:02 UTC) #2

Søren Gjesse

9 years ago (2011-12-13 14:07:39 UTC) #3

http://codereview.chromium.org/8934004/diff/2001/runtime/bin/directory_impl.dart
File runtime/bin/directory_impl.dart (right):

http://codereview.chromium.org/8934004/diff/2001/runtime/bin/directory_impl.d...
runtime/bin/directory_impl.dart:7: int _errorCode;  // Set to OS error code if
process start failed.
On 2011/12/13 13:51:03, Bill Hesse wrote:
> _OSStatus is no longer just used for process starting.

This creates _OSStatus and keeps _ProcessStartStatus. I will consolidate in a
separate change.

http://codereview.chromium.org/8934004/diff/2001/runtime/bin/directory_impl.d...
runtime/bin/directory_impl.dart:50: replyTo.send(status);
On 2011/12/13 13:51:03, Bill Hesse wrote:
> Can we send arbitrary objects between isolates now?  I thought it was just
> values, lists, and maps.

I surely hope so. The tests work.

http://codereview.chromium.org/8934004/diff/2001/runtime/bin/directory_posix.cc
File runtime/bin/directory_posix.cc (right):

http://codereview.chromium.org/8934004/diff/2001/runtime/bin/directory_posix....
runtime/bin/directory_posix.cc:280: strncpy(*path, const_template, PATH_MAX +
1);
On 2011/12/13 13:51:03, Bill Hesse wrote:
> Use SafeStrNCpy here, or remove SafeStrNCpy.

Done.

http://codereview.chromium.org/8934004/diff/2001/tests/standalone/src/Directo...
File tests/standalone/src/DirectoryTest.dart (right):

http://codereview.chromium.org/8934004/diff/2001/tests/standalone/src/Directo...
tests/standalone/src/DirectoryTest.dart:266: if (location != null) {
On 2011/12/13 13:51:03, Bill Hesse wrote:
> Should we use expect.throws() here, instead of writing our own try-catch
block?

Yes, done. I didn't know that existed.

Expand Messages | Collapse Messages