Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 8933029: Add pipe to input stream (Closed)

Created:
9 years ago by Søren Gjesse
Modified:
9 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add pipe to input stream Using the pipe method the data from an input stream can be piped directly to an output stream. R=whesse@google.com, ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2564

Patch Set 1 #

Patch Set 2 : Remove testing code #

Patch Set 3 : Remove more testing code #

Patch Set 4 : Update comment #

Total comments: 10

Patch Set 5 : Address review comments from ager@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -3 lines) Patch
M runtime/bin/builtin_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/file_impl.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/bin/input_stream.dart View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/bin/socket_stream.dart View 2 chunks +6 lines, -0 lines 0 comments Download
A runtime/bin/stream_util.dart View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A tests/standalone/src/StreamPipeTest.dart View 1 2 3 4 1 chunk +267 lines, -0 lines 0 comments Download
A tests/standalone/src/data/dart-logo.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
9 years ago (2011-12-14 12:21:24 UTC) #1
Mads Ager (google)
lgtm LGTM with a couple of comments. http://codereview.chromium.org/8933029/diff/7002/runtime/bin/file.dart File runtime/bin/file.dart (right): http://codereview.chromium.org/8933029/diff/7002/runtime/bin/file.dart#newcode224 runtime/bin/file.dart:224: * Synchronously ...
9 years ago (2011-12-14 13:49:11 UTC) #2
Søren Gjesse
http://codereview.chromium.org/8933029/diff/7002/tests/standalone/src/StreamPipeTest.dart File tests/standalone/src/StreamPipeTest.dart (right): http://codereview.chromium.org/8933029/diff/7002/tests/standalone/src/StreamPipeTest.dart#newcode5 tests/standalone/src/StreamPipeTest.dart:5: // Echo server test program to test socket streams. ...
9 years ago (2011-12-19 07:46:02 UTC) #3
Søren Gjesse
9 years ago (2011-12-19 14:22:31 UTC) #4
http://codereview.chromium.org/8933029/diff/7002/tests/standalone/src/StreamP...
File tests/standalone/src/StreamPipeTest.dart (right):

http://codereview.chromium.org/8933029/diff/7002/tests/standalone/src/StreamP...
tests/standalone/src/StreamPipeTest.dart:82:
getDataFilename("tests/standalone/src/data/dart-logo.png");
On 2011/12/19 07:46:02, Søren Gjesse wrote:
> On 2011/12/14 13:49:11, Mads Ager wrote:
> > Would it be simpler to just use one of the other data files that we have
> already
> > instead of using a png?
> 
> The only data files we have are quite small test files. I wanted a somewhat
> larger binary file, and the dart-logo.png was just at hand.
> 
> Should we maybe have a number of generic test files e.g 1kdata, 4kdata,
16kdata?

Used the existing readline_test1.dat for now.

Powered by Google App Engine
This is Rietveld 408576698