Issue 8932011: Make ElementTests independent of the existing HTML markup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8932011: Make ElementTests independent of the existing HTML markup. (Closed)

Created:
9 years ago by nweiz

Modified:
9 years ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make ElementTests independent of the existing HTML markup. Committed: https://code.google.com/p/dart/source/detail?r=2411

Patch Set 3 : Another code review change. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	client/tests/client/html/ElementTests.dart	View	1 2	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

http://codereview.chromium.org/8932011/diff/3001/client/tests/client/html/ElementTests.dart File client/tests/client/html/ElementTests.dart (right): http://codereview.chromium.org/8932011/diff/3001/client/tests/client/html/ElementTests.dart#newcode69 client/tests/client/html/ElementTests.dart:69: document.body.elements.removeLast(); use container.remove() instead of body.elements.removeLast() who knows if ...

9 years ago (2011-12-14 01:09:28 UTC) #2

nweiz

9 years ago (2011-12-14 01:10:49 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 8932011: Make ElementTests independent of the existing HTML markup. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Absolute #

Patch Set 3 : Another code review change. #

Messages