Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 8923015: Test for frog native properties. (Closed)

Created:
9 years ago by sra1
Modified:
9 years ago
Reviewers:
ahe, Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Test for frog native properties. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2362

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/NativePropertyFrogTest.dart View 1 chunk +52 lines, -0 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
sra1
tbr
9 years ago (2011-12-12 23:18:54 UTC) #1
Jennifer Messerly
lgtm. something mysterious is going on...
9 years ago (2011-12-13 01:08:27 UTC) #2
ahe
http://codereview.chromium.org/8923015/diff/1/tests/language/src/NativePropertyFrogTest.dart File tests/language/src/NativePropertyFrogTest.dart (right): http://codereview.chromium.org/8923015/diff/1/tests/language/src/NativePropertyFrogTest.dart#newcode7 tests/language/src/NativePropertyFrogTest.dart:7: class A native "*A" { Please remove this test ...
9 years ago (2011-12-13 10:23:37 UTC) #3
sra1
http://codereview.chromium.org/8923015/diff/1/tests/language/src/NativePropertyFrogTest.dart File tests/language/src/NativePropertyFrogTest.dart (right): http://codereview.chromium.org/8923015/diff/1/tests/language/src/NativePropertyFrogTest.dart#newcode7 tests/language/src/NativePropertyFrogTest.dart:7: class A native "*A" { On 2011/12/13 10:23:37, ahe ...
9 years ago (2011-12-13 19:13:41 UTC) #4
ahe
http://codereview.chromium.org/8923015/diff/1/tests/language/src/NativePropertyFrogTest.dart File tests/language/src/NativePropertyFrogTest.dart (right): http://codereview.chromium.org/8923015/diff/1/tests/language/src/NativePropertyFrogTest.dart#newcode7 tests/language/src/NativePropertyFrogTest.dart:7: class A native "*A" { On 2011/12/13 19:13:41, sra1 ...
9 years ago (2011-12-13 20:25:07 UTC) #5
Jennifer Messerly
9 years ago (2011-12-13 20:49:18 UTC) #6
On 2011/12/13 20:25:07, ahe wrote:
>
http://codereview.chromium.org/8923015/diff/1/tests/language/src/NativeProper...
> File tests/language/src/NativePropertyFrogTest.dart (right):
> 
>
http://codereview.chromium.org/8923015/diff/1/tests/language/src/NativeProper...
> tests/language/src/NativePropertyFrogTest.dart:7: class A native "*A" {
> On 2011/12/13 19:13:41, sra1 wrote:
> > On 2011/12/13 10:23:37, ahe wrote:
> > > Please remove this test from "language". The native keyword is not part of
> the
> > > Dart language.
> > 
> > Sure, I'll move these tests somewhere under frog.
> 
> thank you!

(probably want to do this for all of the *FrogTest)

Powered by Google App Engine
This is Rietveld 408576698