Changed upload_sdk.py to handle local builds

Changed upload_sdk.py to look for an environment variable and deploy to a different bucket if a developer is running a local editor build.

This prevents local developer builds from ending up on dart-dump-render-tree.
Committed: https://code.google.com/p/dart/source/detail?r=2366

[danrubel, 2011-12-12 20:34:52]

http://codereview.chromium.org/8923007/diff/1/editor/build/build.py
File editor/build/build.py (right):

http://codereview.chromium.org/8923007/diff/1/editor/build/build.py#newcode248
editor/build/build.py:248: from_bucket = 'gs://dart-editor-archive-testing'
In this case, lets skip the copy completely

http://codereview.chromium.org/8923007/diff/1/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://codereview.chromium.org/8923007/diff/1/tools/upload_sdk.py#newcode15
tools/upload_sdk.py:15: GSUTIL =
'/usr/local/google/home/mrrussell/gsutil/gsutil'
Local info... please revert

[Mark R Russell, 2011-12-12 22:01:52]

I did some refactoring of the calls so the build of the sdk will only be done on
the build server and the call to the _CopySdk will only be done if the user name
starts with chrome

http://codereview.chromium.org/8923007/diff/1/editor/build/build.py
File editor/build/build.py (right):

http://codereview.chromium.org/8923007/diff/1/editor/build/build.py#newcode248
editor/build/build.py:248: from_bucket = 'gs://dart-editor-archive-testing'
On 2011/12/12 20:34:53, danrubel wrote:
> In this case, lets skip the copy completely

Done.

http://codereview.chromium.org/8923007/diff/1/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://codereview.chromium.org/8923007/diff/1/tools/upload_sdk.py#newcode15
tools/upload_sdk.py:15: GSUTIL =
'/usr/local/google/home/mrrussell/gsutil/gsutil'
On 2011/12/12 20:34:53, danrubel wrote:
> Local info... please revert

Done.

[danrubel, 2011-12-13 01:15:11]

lgtm

http://codereview.chromium.org/8923007/diff/6003/editor/build/build.py
File editor/build/build.py (right):

http://codereview.chromium.org/8923007/diff/6003/editor/build/build.py#newcod...
editor/build/build.py:244: running_on_buildbot = False
It would be easier to read if these two were under the "else".
Then the "if" block would more closely parallel the "else" block

[Mark R Russell, 2011-12-13 01:19:56]

Handled comments

http://codereview.chromium.org/8923007/diff/6003/editor/build/build.py
File editor/build/build.py (right):

http://codereview.chromium.org/8923007/diff/6003/editor/build/build.py#newcod...
editor/build/build.py:244: running_on_buildbot = False
On 2011/12/13 01:15:11, danrubel wrote:
> It would be easier to read if these two were under the "else".
> Then the "if" block would more closely parallel the "else" block

Done.

[dgrove, 2011-12-13 05:31:31]

http://codereview.chromium.org/8923007/diff/2003/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://codereview.chromium.org/8923007/diff/2003/tools/upload_sdk.py#newcode72
tools/upload_sdk.py:72: sys.stderr.write('cound not find {0}'.format(GSUTIL))
I had intentionally made this not print anything so that it wouldn't cause noise
during development. Do we really need this message?

[Mark R Russell, 2011-12-13 05:37:43]

The reason I put this in was because when I was trying to make this work it
silently failed and it was very confusing.  But I guess that most people do not
actually want to do the upload so a silent failure is not an issue.  

However you know the development team better than I do so I will defer to you
and I can remove it.

On 2011/12/13 05:31:31, dgrove wrote:
> http://codereview.chromium.org/8923007/diff/2003/tools/upload_sdk.py
> File tools/upload_sdk.py (right):
> 
> http://codereview.chromium.org/8923007/diff/2003/tools/upload_sdk.py#newcode72
> tools/upload_sdk.py:72: sys.stderr.write('cound not find {0}'.format(GSUTIL))
> I had intentionally made this not print anything so that it wouldn't cause
noise
> during development. Do we really need this message?