Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 8921012: Allocate double temporaries in old space ... (Closed)

Created:
9 years ago by srdjan
Modified:
9 years ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Allocate double temporaries in old space, because they belong there. Canonicalize more double literals. Committed: https://code.google.com/p/dart/source/detail?r=2351

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M vm/ast.cc View 1 1 chunk +3 lines, -2 lines 2 comments Download
M vm/object.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M vm/opt_code_generator_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M vm/parser.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
9 years ago (2011-12-12 18:28:39 UTC) #1
siva
lgtm http://codereview.chromium.org/8921012/diff/5001/vm/ast.cc File vm/ast.cc (right): http://codereview.chromium.org/8921012/diff/5001/vm/ast.cc#newcode97 vm/ast.cc:97: Double& double_instance = Double::ZoneHandle(Double::New(new_value)); Do you want to ...
9 years ago (2011-12-12 18:50:30 UTC) #2
srdjan
9 years ago (2011-12-21 22:30:16 UTC) #3
http://codereview.chromium.org/8921012/diff/5001/vm/ast.cc
File vm/ast.cc (right):

http://codereview.chromium.org/8921012/diff/5001/vm/ast.cc#newcode97
vm/ast.cc:97: Double& double_instance =
Double::ZoneHandle(Double::New(new_value));
On 2011/12/12 18:50:30, asiva wrote:
> Do you want to allocate this also in the old space?

Done.

Powered by Google App Engine
This is Rietveld 408576698