Issue 8920009: Add Safari to the list of browsers we test on a regular basis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8920009: Add Safari to the list of browsers we test on a regular basis. (Closed)

Created:
9 years ago by Emily Fortuna

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add Safari to the list of browsers we test on a regular basis. Committed: https://code.google.com/p/dart/source/detail?r=2393

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -45 lines)			Patch
M	tools/testing/architecture.py	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/testing/perf_testing/create_graph.py	View	1 2 3	10 chunks	+39 lines, -40 lines	0 comments	Download
A	tools/testing/perf_testing/index.html	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download
M	tools/testing/run_selenium.py	View	1 2 3	5 chunks	+48 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years ago (2011-12-13 01:26:30 UTC) #2

lgtm

http://codereview.chromium.org/8920009/diff/3005/tools/testing/run_selenium.py
File tools/testing/run_selenium.py (right):

http://codereview.chromium.org/8920009/diff/3005/tools/testing/run_selenium.p...
tools/testing/run_selenium.py:61: end_condition = lambda(source): 'PASS' not in
source and 'FAIL' not in source
style nit: I'd make this a function:
def end_condition(source): ...

I'm probably reading it wrong, but wouldn't a 'PASS' or 'FAIL' mean we're done?

in other words, I would expect end_condition to be:
   'PASS' in source or 'FAIL' in source

http://codereview.chromium.org/8920009/diff/3005/tools/testing/run_selenium.p...
tools/testing/run_selenium.py:104: #TODO(efortuna): Don't hard-code this path.
Come up with a better solution.
http://code.google.com/p/selenium/wiki/FirefoxDriver

it looks like the reap_profile option can be set to clear the temporary profile
(although I can't tell if it should be set to True or False ... the help seems
to disagree with the name ... I'd probably grep the source to see how it's used)

Expand Messages | Collapse Messages