Issue 8919025: Added type propagation from store to load locals, but only within a sequence node (not across bas...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8919025: Added type propagation from store to load locals, but only within a sequence node (not across bas... (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Added type propagation from store to load locals, but only within a sequence node (not across basic block). Committed: https://code.google.com/p/dart/source/detail?r=2365

Patch Set 6 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -6 lines)			Patch
M	vm/opt_code_generator_ia32.h	View		3 chunks	+4 lines, -0 lines	0 comments	Download
M	vm/opt_code_generator_ia32.cc	View	1 2 3	13 chunks	+74 lines, -6 lines	0 comments	Download
M	vm/scopes.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	vm/scopes.cc	View	1 2 3 4 5	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with an error to fix. http://codereview.chromium.org/8919025/diff/5001/vm/scopes.h File vm/scopes.h (right): http://codereview.chromium.org/8919025/diff/5001/vm/scopes.h#newcode71 vm/scopes.h:71: (index() == other.index()); ...

9 years ago (2011-12-13 00:31:44 UTC) #2

srdjan

9 years ago (2011-12-13 00:39:38 UTC) #3

http://codereview.chromium.org/8919025/diff/5001/vm/scopes.h
File vm/scopes.h (right):

http://codereview.chromium.org/8919025/diff/5001/vm/scopes.h#newcode71
vm/scopes.h:71: (index() == other.index());
On 2011/12/13 00:31:44, regis wrote:
> This is not correct. You need to check is_captured() and
> owner()->context_level() as well.

Thanks!

Expand Messages | Collapse Messages

Issue 8919025: Added type propagation from store to load locals, but only within a sequence node (not across bas... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Messages