Issue 8918028: If an unhandled exception occurs in Dart_RunLoop, pass it out to the caller.

Issue 8918028: If an unhandled exception occurs in Dart_RunLoop, pass it out to the caller. (Closed)

Created:
9 years ago by turnidge

Modified:
8 years, 11 months ago

Reviewers:
tobyr, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, tobyr

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

If an unhandled exception occurs in Dart_RunLoop, pass it out to the caller.

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -68 lines)			Patch
M	runtime/include/dart_api.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/tests/vm/vm.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	3 chunks	+29 lines, -40 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2	5 chunks	+25 lines, -11 lines	0 comments	Download
M	runtime/vm/dart_entry.h	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View	1 2	1 chunk	+27 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2	3 chunks	+28 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tobyr

http://codereview.chromium.org/8918028/diff/1007/runtime/include/dart_api.h File runtime/include/dart_api.h (right): http://codereview.chromium.org/8918028/diff/1007/runtime/include/dart_api.h#newcode481 runtime/include/dart_api.h:481: * error handle is returned. Is the expectation that ...

9 years ago (2011-12-14 17:48:32 UTC) #3

turnidge

9 years ago (2011-12-14 18:26:55 UTC) #4

http://codereview.chromium.org/8918028/diff/1007/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8918028/diff/1007/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:481: *   error handle is returned.
On 2011/12/14 17:48:32, tobyr wrote:
> Is the expectation that Dart_RunLoop can be successfully re-entered to
continue
> processing messages after an exception?

Yes, if the embedder would like to.

http://codereview.chromium.org/8918028/diff/1007/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8918028/diff/1007/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:724: // TODO(turnidge): Should this call should be
wrapped in a longjmp?
On 2011/12/14 17:48:32, tobyr wrote:
> s/should be/be

Done.

Expand Messages | Collapse Messages