Issue 8916003: Update comments for streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8916003: Update comments for streams (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Bill Hesse, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update comments for streams R=whesse@google.com, ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2426

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -8 lines)			Patch
	M	runtime/bin/input_stream.dart	View		3 chunks	+39 lines, -4 lines	2 comments	Download
	M	runtime/bin/output_stream.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm http://codereview.chromium.org/8916003/diff/1/runtime/bin/input_stream.dart File runtime/bin/input_stream.dart (right): http://codereview.chromium.org/8916003/diff/1/runtime/bin/input_stream.dart#newcode27 runtime/bin/input_stream.dart:27: * will avoid further callbacks until it is ...

9 years ago (2011-12-14 13:36:33 UTC) #2

Søren Gjesse

9 years ago (2011-12-14 13:41:12 UTC) #3

http://codereview.chromium.org/8916003/diff/1/runtime/bin/input_stream.dart
File runtime/bin/input_stream.dart (right):

http://codereview.chromium.org/8916003/diff/1/runtime/bin/input_stream.dart#n...
runtime/bin/input_stream.dart:27: * will avoid further callbacks until it is set
to a functions
On 2011/12/14 13:36:34, Mads Ager wrote:
> a functions -> a function

Done.

Expand Messages | Collapse Messages