Issue 8896017: Port jump and call instruction decoding and patching for x64.

Issue 8896017: Port jump and call instruction decoding and patching for x64. (Closed)

Created:
9 years ago by regis

Modified:
9 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Port jump and call instruction decoding and patching for x64. Committed: https://code.google.com/p/dart/source/detail?r=2327

Patch Set 1 #

Total comments: 3

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+217 lines, -2 lines)			Patch
M	runtime/vm/instructions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A	runtime/vm/instructions_x64.h	View	1 chunk	+99 lines, -0 lines	3 comments	Download
A	runtime/vm/instructions_x64.cc	View	1 chunk	+58 lines, -0 lines	0 comments	Download
A	runtime/vm/instructions_x64_test.cc	View	1 chunk	+55 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with one question. http://codereview.chromium.org/8896017/diff/1/runtime/vm/instructions_x64.h File runtime/vm/instructions_x64.h (right): http://codereview.chromium.org/8896017/diff/1/runtime/vm/instructions_x64.h#newcode12 runtime/vm/instructions_x64.h:12: Does this header file differ ...

9 years ago (2011-12-09 22:39:05 UTC) #2

regis

Thanks http://codereview.chromium.org/8896017/diff/1/runtime/vm/instructions_x64.h File runtime/vm/instructions_x64.h (right): http://codereview.chromium.org/8896017/diff/1/runtime/vm/instructions_x64.h#newcode12 runtime/vm/instructions_x64.h:12: On 2011/12/09 22:39:07, srdjan wrote: > Does this ...

9 years ago (2011-12-09 22:46:29 UTC) #3

srdjan

9 years ago (2011-12-21 22:30:30 UTC) #4

http://codereview.chromium.org/8896017/diff/1/runtime/vm/instructions_x64.h
File runtime/vm/instructions_x64.h (right):

http://codereview.chromium.org/8896017/diff/1/runtime/vm/instructions_x64.h#n...
runtime/vm/instructions_x64.h:12: 
On 2011/12/09 22:46:31, regis wrote:
> On 2011/12/09 22:39:07, srdjan wrote:
> > Does this header file differ from instructions_ia32.h? If not (or only
> > slightly), we should merge the two header files into one.
> 
> They are different, because of the constant defining the length of jump/call
> sequence in bytes.
> I suggest we wait to see how the arm version will look like before trying to
> factorize this header.

Agreed.

Expand Messages | Collapse Messages