Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 8896015: Fix error in buildbot dart-editor-linux (Closed)

Created:
9 years ago by Mark R Russell
Modified:
9 years ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add the JAVA_HOME to the environment for the call to build.py when running on the dart-editor-linux bot Committed: https://code.google.com/p/dart/source/detail?r=2332

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M client/tools/buildbot_annotated_steps.py View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M editor/build/build.py View 1 2 3 3 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark R Russell
Could you review my first attempt to solve the linux build issue
9 years ago (2011-12-09 22:59:05 UTC) #1
Mark R Russell
I now have the code simplified and working and this should solve the build issue ...
9 years ago (2011-12-10 05:09:58 UTC) #2
danrubel
9 years ago (2011-12-10 05:36:23 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698