Use VM specific types if DartC types are not available

Use VM specific types if DartC types are not available
Committed: https://code.google.com/p/dart/source/detail?r=2344

[danrubel, 2011-12-10 15:04:36]

When I override the SystemLibraryProvider to use the VM libraries rather than
the DartC libraries (e.g. dart:core), some of the classes referenced by DartC
don't exist, or rather have different names. This modification first checks for
the DartC specific name, and if that does not exist, checks for the analogous VM
class name.

[srdjan, 2011-12-11 01:04:18]

DBC

http://codereview.chromium.org/8894031/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
(right):

http://codereview.chromium.org/8894031/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java:52:
this.objectArrayType = getType(new String[] {"ListImplementation",
"GrowableObjectArray"}, scope, listener);
Why do you need to know about which classes implement lists? In VM, the
interface List is implemented either by ObjectArray or by GrowableObjectArray.
Those class names will likely be changed.

http://codereview.chromium.org/8894031/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java:55:
this.stringImplementation = getType(new String[] {"StringImplementation",
"GrowableObjectArray"}, scope, listener);
I do not know about StringImplementation, but in VM the interface String is
implemented by One/Two/FourByteString classes. Again, the user should not care
about them.

[scheglov, 2011-12-12 16:02:11]

lgtm

I don't know background, but this change looks safe.

[danrubel, 2011-12-12 16:30:48]

http://codereview.chromium.org/8894031/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
(right):

http://codereview.chromium.org/8894031/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java:52:
this.objectArrayType = getType(new String[] {"ListImplementation",
"GrowableObjectArray"}, scope, listener);
I agree that this is a fragile approach. This is a short term fix to get DartC
analyzing VM code so that we can move forward. I'm hoping someone with more
knowledge in this area can improve or remove this code.

On 2011/12/11 01:04:19, srdjan wrote:
> Why do you need to know about which classes implement lists? In VM, the
> interface List is implemented either by ObjectArray or by GrowableObjectArray.
> Those class names will likely be changed.

http://codereview.chromium.org/8894031/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java:55:
this.stringImplementation = getType(new String[] {"StringImplementation",
"GrowableObjectArray"}, scope, listener);
Good catch. Fixed.

On 2011/12/11 01:04:19, srdjan wrote:
> I do not know about StringImplementation, but in VM the interface String is
> implemented by One/Two/FourByteString classes. Again, the user should not care
> about them.