Issue 8894029: Generate EventListener attributes of non-EventTarget classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8894029: Generate EventListener attributes of non-EventTarget classes. (Closed)

Created:
9 years ago by sra1

Modified:
9 years ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generate EventListener attributes of non-EventTarget classes. Some DOM types have EventListenter attributes but are not EventTargets. For these types we have no choice but to implement the onxxx attributes. This change also reverts the addition of EventTarget to the implemented types of JavaScriptAudioNode. That was a mistake. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2336

Patch Set 1 #

Patch Set 2 : merge #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+842 lines, -82 lines)			Patch
M	client/dom/frog/frog_dom.dart	View	11 chunks	+51 lines, -7 lines	0 comments	Download
M	client/dom/generated/monkey_dom.js	View	11 chunks	+52 lines, -5 lines	0 comments	Download
M	client/dom/generated/src/frog/AudioContext.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/DedicatedWorkerContext.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/FileReader.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/FileWriter.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/IDBDatabase.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/IDBRequest.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/IDBTransaction.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/IDBVersionChangeRequest.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/JavaScriptAudioNode.dart	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	client/dom/generated/src/frog/SharedWorkercontext.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/frog/WorkerContext.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/AudioContext.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/DedicatedWorkerContext.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/FileReader.dart	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/FileWriter.dart	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/IDBDatabase.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/IDBRequest.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/IDBTransaction.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/IDBVersionChangeRequest.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/JavaScriptAudioNode.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	client/dom/generated/src/interface/SharedWorkercontext.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/interface/WorkerContext.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_AudioContextWrappingImplementation.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_DedicatedWorkerContextWrappingImplementation.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_FileReaderWrappingImplementation.dart	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_FileWriterWrappingImplementation.dart	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_IDBDatabaseWrappingImplementation.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_IDBRequestWrappingImplementation.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_IDBTransactionWrappingImplementation.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_IDBVersionChangeRequestWrappingImplementation.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_JavaScriptAudioNodeWrappingImplementation.dart	View	1 chunk	+4 lines, -29 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_SharedWorkercontextWrappingImplementation.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_WorkerContextWrappingImplementation.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/dom/generated/wrapping_dom.js	View	11 chunks	+404 lines, -28 lines	0 comments	Download
M	client/dom/generated/wrapping_dom_externs.js	View	4 chunks	+19 lines, -3 lines	0 comments	Download
M	client/dom/idl/dart/webkit-supplemental.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	client/dom/scripts/dartgenerator.py	View	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

tbr

Expand Messages | Collapse Messages