Fix displaying generic types.

Fix displaying generic types.

Committed: https://code.google.com/p/dart/source/detail?r=2219

[Jennifer Messerly, 2011-12-08 02:19:12]

http://codereview.chromium.org/8888002/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/8888002/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:633: write(a(typeUrl(type), type.genericType.name));
I'd just use:
    write(a(typeUrl(type), type.genericType.name));

and both branches collapse to this one liner :)

That's the main reason that type.genericType returns "this" for non-generic
types. I found it leads to code that's less branchy. (though maybe we need a
different name than "genericType" ... something more like "baseType" or
"typeWithArgs" might be better ...)

[Bob Nystrom, 2011-12-08 02:21:59]

On 2011/12/08 02:19:12, John Messerly wrote:
> http://codereview.chromium.org/8888002/diff/1/utils/dartdoc/dartdoc.dart
> File utils/dartdoc/dartdoc.dart (right):
> 
>
http://codereview.chromium.org/8888002/diff/1/utils/dartdoc/dartdoc.dart#newc...
> utils/dartdoc/dartdoc.dart:633: write(a(typeUrl(type),
type.genericType.name));
> I'd just use:
>     write(a(typeUrl(type), type.genericType.name));
> 
> and both branches collapse to this one liner :)
> 
> That's the main reason that type.genericType returns "this" for non-generic
> types. I found it leads to code that's less branchy. (though maybe we need a
> different name than "genericType" ... something more like "baseType" or
> "typeWithArgs" might be better ...)

Done. +1 for a better name.

[Jennifer Messerly, 2011-12-08 02:23:00]

On 2011/12/08 02:21:59, Bob Nystrom wrote:
> On 2011/12/08 02:19:12, John Messerly wrote:
> > http://codereview.chromium.org/8888002/diff/1/utils/dartdoc/dartdoc.dart
> > File utils/dartdoc/dartdoc.dart (right):
> > 
> >
>
http://codereview.chromium.org/8888002/diff/1/utils/dartdoc/dartdoc.dart#newc...
> > utils/dartdoc/dartdoc.dart:633: write(a(typeUrl(type),
> type.genericType.name));
> > I'd just use:
> >     write(a(typeUrl(type), type.genericType.name));
> > 
> > and both branches collapse to this one liner :)
> > 
> > That's the main reason that type.genericType returns "this" for non-generic
> > types. I found it leads to code that's less branchy. (though maybe we need a
> > different name than "genericType" ... something more like "baseType" or
> > "typeWithArgs" might be better ...)
> 
> Done. +1 for a better name.

lgtm