Issue 8883024: Parse all variations of for-statement.

Issue 8883024: Parse all variations of for-statement. (Closed)

Created:
9 years ago by ahe

Modified:
9 years ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl, Lasse Reichstein Nielsen, floitsch, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Parse all variations of for-statement. Committed: https://code.google.com/p/dart/source/detail?r=2300

Patch Set 2 : Address review comments #

Patch Set 3 : rebased #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -21 lines)			Patch
M	dart/frog/leg/scanner/listener.dart	View	1	6 chunks	+20 lines, -5 lines	0 comments	Download
M	dart/frog/leg/scanner/parser.dart	View		3 chunks	+64 lines, -6 lines	0 comments	Download
M	dart/frog/tests/leg/src/ParserTest.dart	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	dart/frog/tests/leg_only/src/BasicClassTest.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/tests/language/language.status	View	1 2	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM http://codereview.chromium.org/8883024/diff/1/dart/frog/leg/scanner/listener.dart File dart/frog/leg/scanner/listener.dart (right): http://codereview.chromium.org/8883024/diff/1/dart/frog/leg/scanner/listener.dart#newcode80 dart/frog/leg/scanner/listener.dart:80: void endForStatement(int count, Token beginToken, Token endToken) { ...

9 years ago (2011-12-09 08:18:32 UTC) #2

ahe

Hi Nicolas, Thank you for taking a look. Cheers, Peter http://codereview.chromium.org/8883024/diff/1/dart/frog/leg/scanner/listener.dart File dart/frog/leg/scanner/listener.dart (right): http://codereview.chromium.org/8883024/diff/1/dart/frog/leg/scanner/listener.dart#newcode80 ...

9 years ago (2011-12-09 08:57:43 UTC) #3

ngeoffray

9 years ago (2011-12-09 09:12:39 UTC) #4

http://codereview.chromium.org/8883024/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8883024/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:80: void endForStatement(int count, Token
beginToken, Token endToken) {
On 2011/12/09 08:57:43, ahe wrote:
> On 2011/12/09 08:18:32, ngeoffray wrote:
> > int count -> int lastForPartCount?
> 
> How about "updateExpressionCount"?

Works for me!

Expand Messages | Collapse Messages