Issue 8879063: Changes to set up the object tag bits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8879063: Changes to set up the object tag bits (Closed)

Created:
9 years ago by siva

Modified:
9 years ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Changes to set up the object tag bits - sets up canonical - sets up created from a snapshot Added code to capture the tag bits during snapshot generation. Committed: https://code.google.com/p/dart/source/detail?r=2436

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+418 lines, -235 lines)			Patch
M	vm/object.h	View	1 2 3	5 chunks	+24 lines, -7 lines	0 comments	Download
M	vm/object.cc	View	1 2 3	11 chunks	+76 lines, -104 lines	0 comments	Download
M	vm/raw_object.h	View	1 2 3	5 chunks	+40 lines, -3 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View	1 2 3	89 chunks	+211 lines, -89 lines	0 comments	Download
M	vm/snapshot.h	View	1 2 3	2 chunks	+37 lines, -4 lines	0 comments	Download
M	vm/snapshot.cc	View	1 2 3	10 chunks	+30 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8879063/diff/6002/vm/object.cc File vm/object.cc (right): http://codereview.chromium.org/8879063/diff/6002/vm/object.cc#newcode2139 vm/object.cc:2139: // TODO(regis): Should we add null_class_, void_class_, dynamic_class_ ...

9 years ago (2011-12-14 02:53:36 UTC) #2

siva

9 years ago (2011-12-14 18:04:39 UTC) #3

Thanks.

http://codereview.chromium.org/8879063/diff/6002/vm/object.cc
File vm/object.cc (right):

http://codereview.chromium.org/8879063/diff/6002/vm/object.cc#newcode2139
vm/object.cc:2139: // TODO(regis): Should we add null_class_, void_class_,
dynamic_class_ to
On 2011/12/14 02:53:36, regis wrote:
> Feel free to remove this TODO, as discussed.

Done.

Expand Messages | Collapse Messages