Issue 8879056: Fix broken test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8879056: Fix broken test (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix broken test The Expect.throws did not work as expected. TBR=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2386

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	tests/standalone/src/DirectoryTest.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

LGTM. I think it would be better to fix it by removing the final parentheses ...

9 years ago (2011-12-13 14:42:01 UTC) #2

Søren Gjesse

9 years ago (2011-12-13 14:45:48 UTC) #3

Yes, changed it back in http://codereview.chromium.org/8937004/