Issue 8879053: Don't treat stdin from a terminal differently from piped input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8879053: Don't treat stdin from a terminal differently from piped input (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't treat stdin from a terminal differently from piped input Both piped input (when using the "<" to pipe in a file) and terminal input from stdin can set POLLIN with 0 bytes available without POLLHUP when end of file is reached. R=ager@google.com BUG=dart:782 TEST=none Committed: https://code.google.com/p/dart/source/detail?r=2311

Patch Set 1 #

Patch Set 2 : Removed debugging code #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	runtime/bin/eventhandler_linux.cc	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
	M	runtime/bin/eventhandler_macos.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages