Issue 8879052: Add --ast to mini_parser.dart.

Issue 8879052: Add --ast to mini_parser.dart. (Closed)

Created:
9 years ago by ahe

Modified:
9 years ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, karlklose, floitsch, Lasse Reichstein Nielsen, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add --ast to mini_parser.dart. Committed: https://code.google.com/p/dart/source/detail?r=2314

Patch Set 2 : Address review comments #

Patch Set 4 : More failures after merging with Florian's constructor changes #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -51 lines)			Patch
M	dart/frog/leg/scanner/listener.dart	View	1	4 chunks	+17 lines, -5 lines	0 comments	Download
M	dart/frog/leg/scanner/parser.dart	View		5 chunks	+5 lines, -12 lines	0 comments	Download
M	dart/frog/leg/scanner/partial_parser.dart	View	1	1 chunk	+18 lines, -7 lines	0 comments	Download
M	dart/frog/leg/tools/mini_parser.dart	View		6 chunks	+64 lines, -20 lines	0 comments	Download
M	dart/tests/language/language.status	View	1 2 3	1 chunk	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM http://codereview.chromium.org/8879052/diff/1/dart/frog/leg/scanner/listener.dart File dart/frog/leg/scanner/listener.dart (right): http://codereview.chromium.org/8879052/diff/1/dart/frog/leg/scanner/listener.dart#newcode845 dart/frog/leg/scanner/listener.dart:845: pushNode(new FunctionExpression(name, null, null, null)); A reminder of ...

9 years ago (2011-12-09 13:41:27 UTC) #2

ahe

9 years ago (2011-12-09 14:19:47 UTC) #3

Hi Nicolas,

Thank you for your comments.

Cheers,
Peter

http://codereview.chromium.org/8879052/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8879052/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:845: pushNode(new FunctionExpression(name,
null, null, null));
On 2011/12/09 13:41:27, ngeoffray wrote:
> A reminder of our conversation: this node is not really used. And you could
use
> body and formalParmaters (which are null) if you still want to construct it.

Done.

http://codereview.chromium.org/8879052/diff/1/dart/frog/leg/scanner/partial_p...
File dart/frog/leg/scanner/partial_parser.dart (right):

http://codereview.chromium.org/8879052/diff/1/dart/frog/leg/scanner/partial_p...
dart/frog/leg/scanner/partial_parser.dart:42:
listener.handleNoFunctionBody(token);
On 2011/12/09 13:41:27, ngeoffray wrote:
> 'handleNoFunctionBody' is kind of weird to call, even for methods that have a
> body.

I added a comment.

Expand Messages | Collapse Messages