Added constructor for AudioContext for dartc and frog

Added constructor for AudioContext for dartc and frog

Committed: https://code.google.com/p/dart/source/detail?r=2225

[Jennifer Messerly, 2011-12-08 05:11:49]

lgtm

[sra1, 2011-12-08 06:19:16]

A rudimentary test case would be helpful.
I suggest a layout test that calls the constructor,
and checks that the returned value 'is' an AudioContext.

http://codereview.chromium.org/8873008/diff/1/client/dom/generated/src/frog/A...
File client/dom/generated/src/frog/AudioContext.dart (right):

http://codereview.chromium.org/8873008/diff/1/client/dom/generated/src/frog/A...
client/dom/generated/src/frog/AudioContext.dart:3: AudioContext() native;
It is slightly strange to have a plain constructor for a hidden type.  I looked
at the unified browser info and AudioContext is 'hidden' on *all* our target
browsers.

The WebKit IDL for DOMWindow contains
        attribute [JSCCustomGetter,Conditional=WEB_AUDIO,EnabledAtRuntime]
AudioContextConstructor webkitAudioContext; // Usable with new operator

which will appear in the JavaScript global scope.

So the constructor should be:

factory AudioContext() native @'return new webkitAudioContext();';

The dartc version also needs to call the right constructor.

http://codereview.chromium.org/8873008/diff/1/client/dom/scripts/template_wra...
File client/dom/scripts/template_wrapping_dom.js (right):

http://codereview.chromium.org/8873008/diff/1/client/dom/scripts/template_wra...
client/dom/scripts/template_wrapping_dom.js:54: return __dom_wrap(new
AudioContext());
See other comment.
new webkitAudioContext()

[Jennifer Messerly, 2011-12-08 06:31:21]

http://codereview.chromium.org/8873008/diff/1/client/dom/generated/src/frog/A...
File client/dom/generated/src/frog/AudioContext.dart (right):

http://codereview.chromium.org/8873008/diff/1/client/dom/generated/src/frog/A...
client/dom/generated/src/frog/AudioContext.dart:3: AudioContext() native;
On 2011/12/08 06:19:16, sra1 wrote:
> It is slightly strange to have a plain constructor for a hidden type.  I
looked
> at the unified browser info and AudioContext is 'hidden' on *all* our target
> browsers.
> 
> The WebKit IDL for DOMWindow contains
>         attribute [JSCCustomGetter,Conditional=WEB_AUDIO,EnabledAtRuntime]
> AudioContextConstructor webkitAudioContext; // Usable with new operator
> 
> which will appear in the JavaScript global scope.
> 
> So the constructor should be:
> 
> factory AudioContext() native @'return new webkitAudioContext();';
> 
> The dartc version also needs to call the right constructor.

If "webkitAudioContext" is the constructor, why not just make that the native
type name?
It's nice to make things non-hidden when possible.

I tried this out, worked great:
$ webkitAudioContext
function AudioContext() { [native code] }
$ webkitAudioContext.prototype.hello = function(){console.log("hello");}
$ new webkitAudioContext().hello
function (){console.log("hello");}
$ new webkitAudioContext().hello()
hello
$ new webkitAudioContext() instanceof webkitAudioContext
true

[sra1, 2011-12-08 07:29:14]

On 2011/12/08 06:31:21, John Messerly wrote:
>
http://codereview.chromium.org/8873008/diff/1/client/dom/generated/src/frog/A...
> File client/dom/generated/src/frog/AudioContext.dart (right):
> 
>
http://codereview.chromium.org/8873008/diff/1/client/dom/generated/src/frog/A...
> client/dom/generated/src/frog/AudioContext.dart:3: AudioContext() native;
> On 2011/12/08 06:19:16, sra1 wrote:
> > It is slightly strange to have a plain constructor for a hidden type.  I
> looked
> > at the unified browser info and AudioContext is 'hidden' on *all* our target
> > browsers.
> > 
> > The WebKit IDL for DOMWindow contains
> >         attribute [JSCCustomGetter,Conditional=WEB_AUDIO,EnabledAtRuntime]
> > AudioContextConstructor webkitAudioContext; // Usable with new operator
> > 
> > which will appear in the JavaScript global scope.
> > 
> > So the constructor should be:
> > 
> > factory AudioContext() native @'return new webkitAudioContext();';
> > 
> > The dartc version also needs to call the right constructor.
> 
> If "webkitAudioContext" is the constructor, why not just make that the native
> type name?
> It's nice to make things non-hidden when possible.

But it is even nicer to make things standard.

The WebKit IDL declares the type as AudioContext.
w3c describes AudioContext:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioCo...
They are not the same but are on a path to being the same, and have a lot of
common functionality.
Many things called webkitXXX are on a path to being called XXX.

> 
> I tried this out, worked great:
> $ webkitAudioContext
> function AudioContext() { [native code] }
> $ webkitAudioContext.prototype.hello = function(){console.log("hello");}
> $ new webkitAudioContext().hello
> function (){console.log("hello");}
> $ new webkitAudioContext().hello()
> hello
> $ new webkitAudioContext() instanceof webkitAudioContext
> true